[cgrey8]

I'm finding some wrong data for this function in the defs. The units I have don't match the description or what I read about this function in the GUFB strategy doc.

Can someone confirm for me what exactly this function does as well as confirm the units & conversion for both X and Y?

[jsa]

The X column units are as per ECT as ECT is the input for FN393F.
The Y column units are compared to MULTMR so must be the same units as MULTMR. mSec or X/1024Sec.

From TVRfans disassembly

Code: Select all

4a32: 45,18,00,f0,32      ad3w  R32,Rf0,18       R32 = Func1;
4a37: b0,b0,34            ldb   R34,Rb0          R34 = ECT;
4a3a: ef,6f,eb            call  35ac             subyteLU();
4a3d: 9b,72,c7,38         cmpb  R38,[R72+c7]     
4a41: d9,1a               jgtu  4a5d             if ((uns) R38 <= Multmr)  {
4a43: a3,72,e8,30         ldw   R30,[R72+e8]     R30 = Lammul;
4a47: 89,00,01,30         cmpw  R30,100          
4a4b: df,10               je    4a5d             if (R30 != 100)  {
4a4d: d9,04               jgtu  4a53             if ((uns) R30 > 100 ) goto 4a53 ;
4a4f: 07,30               incw  R30              R30++;
4a51: 20,02               sjmp  4a55             goto 4a55 ;

4a53: 05,30               decw  R30              R30--;
4a55: c3,72,e8,30         stw   R30,[R72+e8]     Lammul = R30;
4a59: c7,72,c7,00         stb   R0,[R72+c7]      Multmr = 0; } }
.
.
.
   Func1:
8c18: 7f,19   func               127, 25
8c1a: 23,19   func                35, 25
8c1c: 1e,2d   func                30, 45
8c1e: 80,2d   func              -128, 45
8c20: 80,2d   func              -128, 45
8c22: 80,2d   func              -128, 45
8c24: 80,2d   func              -128, 45

[cgrey8]

And what's the equation for ECT? I've got one def that's defining it as X*2 and another that has X/128.

I went looking for another 1-byte function that compares a sec to temp, and the only one I could find was FN400. And while I know that's not an apples-to-apples comparison, it seemed as good as I could do without the skill to be able to read the code and figure it out for myself.

But FN400 isn't exactly a commonly used function. If it's got problems, I don't know that anybody would notice it either. So I decided to not make assumptions, and just ask...hence this thread.

What's even worse, is I'm trying to determine if the problem with bad conversions is related to moving and reordering rows in the def. One of the issues with v99 that EDS found was related to a whole block of formulas were shifted down making every line in that area have the wrong conversion. Once I realized that, it was easier to fix by deleting a cell and letting all the other cells shift up, then re-inserting the deleted cell where it belonged. But even this is risky and is very error-prone.

I almost wish these def files were actually stored in a database format, and the def, as we see it, is a generated export of that database, so stuff like this couldn't get out of sync so easily when things need to be renamed and thus re-ordered. But that's a whole can of worms that I'm not sure is worth the effort at this point unless there's someone out there looking to support hundreds of defs and they'd like each known PID to be individually entered and associated with specific strategy codes. Now that I'm thinking about it, I'm not sure it'd be that difficult to program.

I might talk to Clint and see if he'd be interested in helping to throw something together. I've got C# experience and application logic experience, but I suck at UIs. He's got far more UI experience.

[jsa]

Which 2 defs are you comparing?

X*2 for this gufb function by the look of it.

[cgrey8]

At the time, it was GUF1 and GUFB. I'll update GUFA once I get confidence on what the value should be.

[jsa]

For the ultimate in confidence log ECT.
The equation will be the same as the ECT payload.